Re: cvs commit: src/sys/i386/cpufreq est.c

On Tuesday 11 March 2008 02:21:20 pm Abdullah Ibn Hamad Al-Marri wrote:
> ----- Original Message ----
> > From: John Baldwin <jhb_at_FreeBSD.org>
> > To: Abdullah Ibn Hamad Al-Marri <wearabnet_at_yahoo.ca>
> > Cc: cvs-src_at_FreeBSD.org; src-committers_at_FreeBSD.org; Rui Paulo 
<rpaulo_at_FreeBSD.org>
> > Sent: Tuesday, March 11, 2008 12:56:23 AM
> > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c
> > 
> > On Monday 10 March 2008 04:53:57 pm Abdullah Ibn Hamad Al-Marri wrote:
> > > ----- Original Message ----
> > > > From: John Baldwin 
> > > > To: Abdullah Ibn Hamad Al-Marri 
> > > > Cc: cvs-src_at_FreeBSD.org; src-committers_at_FreeBSD.org; Rui Paulo 
> > 
> > > > Sent: Monday, March 10, 2008 7:56:56 PM
> > > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c
> > > > 
> > > > On Saturday 08 March 2008 11:33:13 am Abdullah Ibn Hamad Al-Marri 
wrote:
> > > > > ----- Original Message ----
> > > > > > From: Rui Paulo 
> > > > > > To: Abdullah Ibn Hamad Al-Marri 
> > > > > > Cc: src-committers_at_freebsd.org; cvs-src_at_freebsd.org; 
> > cvs-all_at_freebsd.org
> > > > > > Sent: Saturday, March 8, 2008 6:38:10 PM
> > > > > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c
> > > > > > 
> > > > > > On Sat, Mar 8, 2008 at 2:21 PM, Abdullah Ibn Hamad Al-Marri
> > > > > >  wrote:
> > > > > > >
> > > > > > > ----- Original Message ----
> > > > > > >
> > > > > > > > From: Rui Paulo 
> > > > > > > > To: src-committers_at_FreeBSD.org; cvs-src_at_FreeBSD.org; 
> > > > cvs-all_at_FreeBSD.org
> > > > > > > > Sent: Saturday, March 8, 2008 5:12:35 PM
> > > > > > > > Subject: cvs commit: src/sys/i386/cpufreq est.c
> > > > > > > >
> > > > > > > > rpaulo      2008-03-08 14:12:35 UTC
> > > > > > > >
> > > > > > > >   FreeBSD src repository
> > > > > > > >
> > > > > > > >   Modified files:        (Branch: RELENG_7)
> > > > > > >
> > > > > > > >     sys/i386/cpufreq    est.c
> > > > > > > >   Log:
> > > > > > > >   MFC r1.12:
> > > > > > > >     Validate the id16 values gathered from ACPI (previously a 
TODO
> > > > > > > >     item).
> > > > > > > >     Style changes by me and njl.
> > > > > > > >
> > > > > > > >     Submitted by:    Takeharu KATO
> > > > > > > >     PR:              119350
> > > > > > > >
> > > > > > > >   Revision  Changes    Path
> > > > > > > >   1.11.2.1  +59 -17    src/sys/i386/cpufreq/est.c
> > > > > > >
> > > > > > > Thanks, how about AMD64?
> > > > > > 
> > > > > > This directory is shared by i386 and amd64.
> > > > > > 
> > > > > > Regards.
> > > > > > -- 
> > > > > > Rui Paulo
> > > > > > 
> > > > > 
> > > > > 
> > > > > Thank you,
> > > > > 
> > > > > Here what I got.
> > > > > FreeBSD 7.0-STABLE #0: Sat Mar  8 16:16:54 UTC 2008
> > > > >     arabian_at_MX1.WeArab.Net:/usr/obj/usr/src/sys/MX1
> > > > > Timecounter "i8254" frequency 1193182 Hz quality 0
> > > > > CPU: Intel(R) Core(TM)2 Duo CPU     E6750  _at_ 2.66GHz (2666.62-MHz 
> > K8-class 
> > > > CPU)
> > > > >   Origin = "GenuineIntel"  Id = 0x6fb  Stepping = 11
> > > > >   
> > > > Features=0xbfebfbff
> > > > >   
> > > > Features2=0xe3fd
> > > > >   AMD Features=0x20100800
> > > > >   AMD Features2=0x1
> > > > >   Cores per package: 2
> > > > > usable memory = 4276043776 (4077 MB)
> > > > > avail memory  = 4106977280 (3916 MB)
> > > > > ACPI APIC Table: 
> > > > > FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
> > > > >  cpu0 (BSP): APIC ID:  0
> > > > >  cpu1 (AP): APIC ID:  1
> > > > > ioapic0  irqs 0-23 on motherboard
> > > > > acpi0:  on motherboard
> > > > > acpi0: [ITHREAD]
> > > > > acpi0: Power Button (fixed)
> > > > > Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000
> > > > > acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0
> > > > > acpi_hpet0:  iomem 0xfed00000-0xfed003ff on 
> > > > acpi0
> > > > > Timecounter "HPET" frequency 14318180 Hz quality 900
> > > > > cpu0:  on acpi0
> > > > > est0:  on cpu0
> > > > > est: CPU supports Enhanced Speedstep, but is not recognized.
> > > > > est: cpu_vendor GenuineIntel, msr 82a082a0600082a
> > > > > device_attach: est0 attach returned 6
> > > > > p4tcc0:  on cpu0
> > > > > cpu1:  on acpi0
> > > > > est1:  on cpu1
> > > > > est: CPU supports Enhanced Speedstep, but is not recognized.
> > > > > est: cpu_vendor GenuineIntel, msr 82a082a0600082a
> > > > > device_attach: est1 attach returned 6
> > > > > p4tcc1:  on cpu1
> > > > 
> > > > Try www.freebsd.org/~jhb/patches/est_msr.patch
> > > > 
> > > > -- 
> > > > John Baldwin
> > > 
> > > Hey John
> > > 
> > > FreeBSD is a registered trademark of The FreeBSD Foundation.
> > > FreeBSD 7.0-STABLE #1: Mon Mar 10 20:43:50 UTC 2008
> > >     arabian_at_MX1.WeArab.Net:/usr/obj/usr/src/sys/MX1
> > > Timecounter "i8254" frequency 1193182 Hz quality 0
> > > CPU: Intel(R) Core(TM)2 Duo CPU     E6750  _at_ 2.66GHz (2666.62-MHz 
K8-class 
> > CPU)
> > >   Origin = "GenuineIntel"  Id = 0x6fb  Stepping = 11
> > >   
> > Features=0xbfebfbff
> > > HTT,TM,PBE>
> > >   
> > Features2=0xe3fd
> > >   AMD Features=0x20100800
> > >   AMD Features2=0x1
> > >   Cores per package: 2
> > > usable memory = 4276043776 (4077 MB)
> > > avail memory  = 4106977280 (3916 MB)
> > > ACPI APIC Table: 
> > > FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
> > >  cpu0 (BSP): APIC ID:  0
> > >  cpu1 (AP): APIC ID:  1
> > > ioapic0  irqs 0-23 on motherboard
> > > acpi0:  on motherboard
> > > acpi0: [ITHREAD]
> > > acpi0: Power Button (fixed)
> > > Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000
> > > acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0
> > > acpi_hpet0:  iomem 0xfed00000-0xfed003ff on 
> > acpi0
> > > Timecounter "HPET" frequency 14318180 Hz quality 900
> > > cpu0:  on acpi0
> > > est0:  on cpu0
> > > est0: Guessed bus clock (high) of 333 MHz
> > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > est0: Guessed bus clock (low) of 333 MHz
> > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > est: CPU supports Enhanced Speedstep, but is not recognized.
> > > est: cpu_vendor GenuineIntel, msr 82a082a0600082a
> > >                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > device_attach: est0 attach returned 6
> > > p4tcc0:  on cpu0
> > 
> > Unless you really have a bus clock of 333 (in which case the test needs to 
be 
> > updated) the MSR's don't add up.  You can try changing the statement that 
> > tests for 100 or 133 to accept 333 as well.
> > 
> > -- 
> > John Baldwin
> 
> John,
> 
> Thanks for getting back to me, I'm not hardware guy.
> 
> Do you mean the cpu bus speed 1033 or what?
> 
> How could I test it?

Yes, a bus speed of 333.  In the original patch it has lines that say:

	if (bus != 100 && bus != 133) {
		...
	}

you would just change that to:

	if (bus != 100 && bus != 133 && bus != 333) {
		...
	}

-- 
John Baldwin