Re: ndis(4) patch to replace obsolete if_watchdog interface

From: Coleman Kane <cokane_at_FreeBSD.org>
Date: Thu, 29 May 2008 19:45:31 -0400
On Thu, 2008-05-29 at 14:46 -0700, Andrew Thompson wrote:
> On Thu, May 29, 2008 at 04:41:32PM -0400, Coleman Kane wrote:
> > Hi,
> > 
> > I just replaced the obsoleted if_watchdog interface in ndis(4) with a
> > local implementation. This should remove the obnoxious warning message
> > on device init. Anyone using -CURRENT with an ndis card, could you send
> > me success/fails?
> > 
> > The patch is here:
> >   * http://people.freebsd.org/~cokane/patches/if_ndis-new_wd.patch
> 
> 
> This works different to the rest of the network drivers. The existing
> drivers use a callout tick that runs while the driver is up and an
> integer counter.
> 
>  if (x && --x == 0)
> 	 ...timeout...
> 
> You arm the callout and stop it after each Tx, does this have any
> perfornace impact?
> 
> 
> Andrew
> 

I am attaching a new patch, where I use the method that you suggested
and do away with the extra callout for the watchdog. A "tick" function
was already implemented for timeouts related to the NDIS systems.

I am not sure if the ndis-timeout code using ndis_stat_callout
duplicates the if_watchdog code (and what I replaced it with), but I
don't think so as both were implemented side-by-side before...

-- 
Coleman Kane

Received on Thu May 29 2008 - 21:46:55 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:31 UTC