Re: NFS regression.

From: Doug Rabson <dfr_at_rabson.org>
Date: Mon, 17 Nov 2008 18:07:52 +0000
On 17 Nov 2008, at 18:02, Pawel Jakub Dawidek wrote:

> On Mon, Nov 17, 2008 at 05:54:02PM +0000, Doug Rabson wrote:
>>
>> On 17 Nov 2008, at 17:10, Pawel Jakub Dawidek wrote:
>>
>>> Hi.
>>>
>>> I'm seeing this panic very often now with few days old HEAD:
>>>
>>>
>>> Any ideas?
>>
>> Can you reproduce this with INVARIANTS turned on? That should trigger
>> a KASSERT a bit earlier and give me a chance to fix the thing.
>
> I've INVARIANTS on... Is there some assertion added recently you are
> expecting?

Hmm. I added an assert in r184921 which ought to have caught this.  
Could you try this patch and see if it changes anything:

Index: rpc/clnt_dg.c
===================================================================
--- rpc/clnt_dg.c	(revision 184968)
+++ rpc/clnt_dg.c	(working copy)
_at__at_ -543,7 +543,7 _at__at_

  		if (tv > 0) {
  			if (cu->cu_closing || cu->cu_closed)
-				error = 0;
+				error = ESHUTDOWN;
  			else
  				error = msleep(cr, &cs->cs_lock,
  				    cu->cu_waitflag, cu->cu_waitchan, tv);
Received on Mon Nov 17 2008 - 17:07:54 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:37 UTC