Re: NFS regression.

On 18 Nov 2008, at 18:18, Pawel Jakub Dawidek wrote:

> On Tue, Nov 18, 2008 at 09:13:26AM +0000, Doug Rabson wrote:
>>
>> On 17 Nov 2008, at 18:37, Pawel Jakub Dawidek wrote:
>>
>>> On Mon, Nov 17, 2008 at 06:07:52PM +0000, Doug Rabson wrote:
>>>>
>>>> On 17 Nov 2008, at 18:02, Pawel Jakub Dawidek wrote:
>>>>
>>>>> On Mon, Nov 17, 2008 at 05:54:02PM +0000, Doug Rabson wrote:
>>>>>>
>>>>>> On 17 Nov 2008, at 17:10, Pawel Jakub Dawidek wrote:
>>>>>>
>>>>>>> Hi.
>>>>>>>
>>>>>>> I'm seeing this panic very often now with few days old HEAD:
>>>>>>>
>>>>>>>
>>>>>>> Any ideas?
>>>>>>
>>>>>> Can you reproduce this with INVARIANTS turned on? That should
>>>>>> trigger
>>>>>> a KASSERT a bit earlier and give me a chance to fix the thing.
>>>>>
>>>>> I've INVARIANTS on... Is there some assertion added recently you  
>>>>> are
>>>>> expecting?
>>>>
>>>> Hmm. I added an assert in r184921 which ought to have caught this.
>>>> Could you try this patch and see if it changes anything:
>>>>
>>>> Index: rpc/clnt_dg.c
>>>> ===================================================================
>>>> --- rpc/clnt_dg.c	(revision 184968)
>>>> +++ rpc/clnt_dg.c	(working copy)
>>>> _at__at_ -543,7 +543,7 _at__at_
>>>>
>>>> 		if (tv > 0) {
>>>> 			if (cu->cu_closing || cu->cu_closed)
>>>> -				error = 0;
>>>> +				error = ESHUTDOWN;
>>>> 			else
>>>> 				error = msleep(cr, &cs->cs_lock,
>>>> 				    cu->cu_waitflag, cu->cu_waitchan, tv);
>>>>
>>>
>>> Ok, my source is older and doesn't contain the assertion you  
>>> added. I
>>> applied the patch above and also added assertion by hand (I'm not
>>> setup
>>> now to upgrade entire system). This is the panic I get with the new
>>> kernel:
>>>
>>> ...
>>>
>>> If you want me to convert some of those to file:line, just let me
>>> know.
>>
>> Don't worry about line numbers - I can see where its calling from. Do
>> you have a recipe for reproducing this? Also, could you try this  
>> patch
>> instead of the previous:
>>
>> Index: rpc/clnt_dg.c
>> ===================================================================
>> --- rpc/clnt_dg.c	(revision 184968)
>> +++ rpc/clnt_dg.c	(working copy)
> [...]
>
> With this patch it still panics here:

I wasn't expecting this to fix the panic, just move it to an earlier  
spot :(

>
> I can reproduce it easly. I've a netbooted system where I start
> 'make -ssj4 buildworld', but both src/ and obj/ directories are on  
> local
> ZFS file system. So only all the system tools and libraries are on  
> NFS.
> I'm using UDP for NFS, BTW. Sorry for not mentioning it earlier:

I got the UDP part (clnt_dg is responsible for RPC over UDP). I will  
see if I can put together a similar setup here.