Re: Patch for bin/54446

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

insomniac wrote:
> Hi to everyone,
> I wrote a patch for the bin/54446 PR, fixing pkg_delete(1) that doesn't
> honour symlinks, and portupgrades leads to failing services.
> 
> Actually, this patch fixes that for all the utilities as it acts
> directly in the lib.
> 
> I tested the patch on a few x86 machines, ranging from 7.0 to -HEAD.
> Testing and further reviewing are welcome and encouraged.
> 
> pkg_delete now seems to work fine; moreover I found other bugs, like
> memory leaks, missing checks of function return values, and wrong return
> values.
> 
> The patch has already been reviewed by attilio_at_ , it applies to
> src/usr.sbin/pkg_install/lib/plist.c and is located at
> 
> http://insomniac.slackware.it/plist.c.diff

I have made a small change: use malloc() here and use strlcpy().  Other
parts looks just fine.

(BTW I think we need to cc portmgr_at_ for approval)

Cheers,
- --
Xin LI <delphij_at_delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkksw5EACgkQi+vbBBjt66CVaACfRah4OMrOiFZKzJ3DvzjTnl3K
sE8AnRQeL3lKC/fSnzJn89IQHMAgoudI
=loiW
-----END PGP SIGNATURE-----