Re: [head tinderbox] failure on i386/i386

From: Ed Schouten <ed_at_80386.nl>
Date: Wed, 22 Oct 2008 10:03:26 +0200
* FreeBSD Tinderbox <tinderbox_at_freebsd.org> wrote:
> cc1: warnings being treated as errors
> /src/sys/dev/ppbus/lpt.c: In function 'lpt_attach':
> /src/sys/dev/ppbus/lpt.c:402: warning: assignment makes pointer from integer without a cast
> /src/sys/dev/ppbus/lpt.c: In function 'lptopen':
> /src/sys/dev/ppbus/lpt.c:479: warning: assignment makes integer from pointer without a cast

What about this?

%%%
--- sys/dev/ppbus/lpt.c
+++ sys/dev/ppbus/lpt.c
_at__at_ -392,14 +392,12 _at__at_
 	lpt_release_ppbus(dev);
 
 	sc->dev = dev;
-	sc->cdev = make_dev(&lpt_cdevsw, unit,
+	sc->cdev = make_dev(&lpt_cdevsw, 0,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d", unit);
 	sc->cdev->si_drv1 = sc;
-	sc->cdev->si_drv2 = 0;
-	sc->cdev_bypass = make_dev(&lpt_cdevsw, unit,
+	sc->cdev_bypass = make_dev(&lpt_cdevsw, LP_BYPASS,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d.ctl", unit);
 	sc->cdev_bypass->si_drv1 = sc;
-	sc->cdev_bypass->si_drv2 = LP_BYPASS;
 	return (0);
 }
 
_at__at_ -476,7 +474,7 _at__at_
 	} else
 		sc->sc_state |= LPTINIT;
 
-	sc->sc_flags = dev->si_drv2;
+	sc->sc_flags = dev2unit(dev);
 
 	/* Check for open with BYPASS flag set. */
 	if (sc->sc_flags & LP_BYPASS) {
%%%

-- 
 Ed Schouten <ed_at_80386.nl>
 WWW: http://80386.nl/

Received on Wed Oct 22 2008 - 06:03:28 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:36 UTC