Re: Parenthesizing problem in sys/i386/i386/identcpu.c

On Wednesday 22 October 2008 04:58 pm, Jung-uk Kim wrote:
> On Wednesday 22 October 2008 04:44 pm, David Wolfskill wrote:
> > This was from around line 847; whine I saw was:
> > >>> Kernel build for FREEBEAST started on Wed Oct 22 12:50:05 PDT
> > >>> 2008
> >
> > ...
> >
> > >>> stage 3.2: building everything
> >
> > ...
> > cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls
> > -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
> > -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
> > -fformat-extensions -nostdinc  -I. -I/usr/src/sys
> > -I/usr/src/sys/contrib/altq -D_KERNEL
> > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
> > -finline-limit=8000 --param inline-unit-growth=100 --param
> > large-function-growth=1000 -mno-align-long-strings
> > -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse
> > -mno-sse2 -mno-sse3 -ffreestanding
> > -fstack-protector -Werror  /usr/src/sys/i386/i386/identcpu.c cc1:
> > warnings being treated as errors
> > /usr/src/sys/i386/i386/identcpu.c: In function 'printcpuinfo':
> > /usr/src/sys/i386/i386/identcpu.c:847: warning: suggest
> > parentheses around && within ||
> > /usr/src/sys/i386/i386/identcpu.c:847: error: expected statement
> > before ')' token *** Error code 1
> >
> > Stop in /common/S4/obj/usr/src/sys/FREEBEAST.
> > *** Error code 1
> >
> > Stop in /usr/src.
> > [End of excerpt...]
> >
> > The attached patch got me through the buildkernel, and the
> > resulting kernel booted OK -- for me.  I'm only using the i386
> > arch; I don't know if there might be similar issues for any other
> > arch.
> >
> > It applied to rev. 1.190 of src/sys/i386/i386/identcpu.c. 
> > (Sorry; I'm still reading about Subversion, and haven't got my
> > thinking converted yet.)
>
> It's already fixed on head:
>
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/i386/identcpu.c.
>diff?r1=1.190;r2=1.192
>
> Sorry for the inconvenience,

Doh, there is a copy-and-pasto!  Will fix soon.

Today is not my day. :-(

Jung-uk Kim