Re: cp(1) and mmap

Diomidis Spinellis wrote:
> Diomidis Spinellis wrote:
>> Andriy Gapon wrote:
>>> on 28/05/2008 12:02 Harti Brandt said the following:
>>>> Hi all,
>>>>
>>>> it looks like there is no fallback in cp(1) when mmaping the source 
>>>> file
>>>> fails. I'm mounting SMB shares via smbnetfs (which in turn uses fuse)
>>>> and it seems not to support mmaping files. Shouldn't cp just 
>>>> fallback to
>>>> a normal read()/write() loop in this case?
>>>
>>> I would think that it should.
>>> This topic was brought up several times, but no resolution so far.
>>> I think that I've even seen patches.
>>>
>>
>> I've not seen the patches, but the fix is trivial (see the attached 
>> patch).  If there are no objections, I can commit it.
>
> Fix committed in 184342.  Sorry for the long delay.
>
No problem. Thanks. I had this still in my inbox and was several times 
about to commit it, but was distracted each time. Thanks, this helps alot.

harti
> - dds
>