Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c

From: Eygene Ryabinkin <rea-fbsd_at_codelabs.ru>
Date: Wed, 24 Sep 2008 09:26:26 +0400
Good day.

Tue, Sep 23, 2008 at 02:02:50PM +0400, Eygene Ryabinkin wrote:
> The attached patch was tested on two 7.1-PRERELEASE systems (i386 and
> amd64, both with and without X), on 7.0-STABLE and 7.0-RELEASE-p3 (i386,
> only console, no X) and on rather old 8-CURRENT from Jul 1, syscons.c
> revision 1.459 (amd64 both with and without X).  Works fine for me.
> 
> 8.x needs slightly modified patch due to the naming changes.  Also
> attached it.  Will try a fresher -CURRENT in some hours: Ed did massive
> changes due to the MPSAFE tty layer, so may be this patch won't be
> needed for the modern 8-CURRENT.

Tested the patches on the 8-CURRENT from yesterday: system is stable, no
side effects both in console and X.  As the bonus, I had noticed that
the strange keyboard behaviour that I used to see on my laptop is
disappeared.  The effect was the following: after some hours of laptop
inactivity, keyboard input was slow as if a delay of about a second was
introduced between keyboard clicks.  I had this only on console, X
worked fine.  But now, after 12 hours of laptop inactivity, all works
fine, no delays.  May be this is due to the locking changes introduced
by the current patches.
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual   
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook 
    {_.-``-'         {_/            #

Received on Wed Sep 24 2008 - 03:26:30 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:35 UTC