On 2 Aug 2009, at 17:09, Christoph Mallon wrote: > Alban Hertroys schrieb: >> Not being familiar with x86 assembly doesn't help me here of >> course, the last time I touched assembly was on a Z80 a couple of >> decades back... > > Similarily, if you are not familiar with C, then ++i; will puzzle > you. Do you want to add /* add one to the integer variable named i > */ everywhere? > But you've got one point: There should be a comment added, which > states that the if () is just an optimisation. Ah sorry, that wasn't meant as a comment on the lack of comments on assembly code but merely as an aside that _I_ can't really comment on assembly code due to my lack of experience with it. I trust that most FreeBSD developers have no issues with reading assembly like this, so there is no real need to add comments there (unless something it does isn't immediately obvious of course). Alban Hertroys -- If you can't see the forest for the trees, cut the trees and you'll see there is no forest. !DSPAM:930,4a75b2c210131568315957!Received on Sun Aug 02 2009 - 13:37:40 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:53 UTC