FW: 8.0-BETA2 sysinstall ignoring setting of nonInteractive

Can someone "PLEASE" commit this fix.

Daniel was kind enough to write it up, but it has not been committed as of
8/3/2009.

Thanks.

-----Original Message-----
From: Daniel O'Connor [mailto:doconnor_at_gsoft.com.au]
Sent: Tuesday, July 21, 2009 8:28 PM
To: freebsd-current_at_freebsd.org
Cc: David Boyd
Subject: Re: 8.0-BETA2 sysinstall ignoring setting of nonInteractive


On Wed, 22 Jul 2009, David Boyd wrote:
> With 8.0-BETA(1/2) sysinstall ignores setting of nonInteractive
> variable when using USB-based install.
>
> With or without nonInteractive sysinstall issues message "Using USB
> device: da0a" and waits for confirmation.
>
> This breaks unattended installations using USB device.

I think this would fix it, can you test it?

Index: media.c
===================================================================
--- media.c     (revision 195813)
+++ media.c     (working copy)
_at__at_ -262,7 +262,8 _at__at_
                mediaDevice = devs[0];
        if (mediaDevice)
                mediaDevice->private = NULL;
-       msgConfirm("Using USB device: %s", mediaDevice->name);
+       if (!variable_get(VAR_NONINTERACTIVE))
+               msgConfirm("Using USB device: %s", mediaDevice->name);
        return (mediaDevice ? DITEM_LEAVE_MENU : DITEM_FAILURE);
 }


--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
  -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C