Re: 8.0-BETA2: mi_startup() panic on VIA C7 diskless

From: John Baldwin <jhb_at_freebsd.org>
Date: Wed, 12 Aug 2009 09:24:48 -0400
On Tuesday 11 August 2009 6:21:28 pm Julian Elischer wrote:
> Ed Schouten wrote:
> > * Kip Macy <kmacy_at_freebsd.org> wrote:
> >> http://people.freebsd.org/~kmacy/flowtable_boot.patch
> > 
> > +	if ((V_flowtable_enable == 0) || (V_flowtable_ready == 0)
> > 
> > should probably read:
> > 
> > +	if (V_flowtable_enable == 0 || V_flowtable_ready == 0)
> > 
> > Right?
> > 
> 
> 
> I prefer the first, with an extra closing paren.

style(9) prefers the latter assuming that it isn't confusing to read the 
latter (I do not think it is).

-- 
John Baldwin
Received on Wed Aug 12 2009 - 11:32:20 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:53 UTC