2009/8/13 Doug Barton <dougb_at_freebsd.org>: >> if [ -n "$svnversion" -a -d "${SRCDIR}/.svn" ] ; then >> - svn=" r`cd $SRCDIR && $svnversion`" >> + # If we are called from the kernel build, limit >> + # the scope of svnversion to sys/ . >> + if [ -e "${SRCDIR}/sys/conf/newvers.sh" ] ; then > > I missed this when it went through originally, so my apologies for the > late response, but I don't see any way that this first test can ever > not be true. Is there a better way to detect if the script is called > in the buildkernel process? > > Also, what problem are we really trying to solve here? With a > populated cache it takes on average 5 seconds to run all of src, and > just under 1 to do only sys. Is 4 seconds really that important to > save? With a dry cache I'm sure it takes a little longer, but has > anyone actually measured this? How about 'svn info' ? It will also hide M,S suffixes for modified and/or switched working copies. svn=" r`svn info $SRCDIR 2>/dev/null | awk '/^Revision:/ {print $2}'`" -- Artis Caune Everything should be made as simple as possible, but not simpler.Received on Thu Aug 13 2009 - 19:55:31 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:53 UTC