Re: Could you please fix this ?

On Thursday 03 December 2009 09:27 pm, Leonardo Santagostini wrote:
> Sorry, but ive not backed up this file, instead of this, i will
> copy the entire function (in fact its very short)
>
> cpi_pcib_pci_attach(device_t dev)
> {
>     struct acpi_pcib_softc *sc;
>     ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
>
>     if (device_get_unit(dev)==2){
>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
> PCIM_CMD_PORTEN, 1);
>         pci_enable_busmaster(dev);
>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf020, 2);
>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf020, 2);
>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
>     }
>     if (device_get_unit(dev)==3){
>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
> PCIM_CMD_PORTEN, 1);
>         pci_enable_busmaster(dev);
>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf030, 2);
>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf030, 2);
>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
>     }
>
>     pcib_attach_common(dev);
>     sc = device_get_softc(dev);
>     sc->ap_handle = acpi_get_handle(dev);
>   return (acpi_pcib_attach(dev, &sc->ap_prt,
> sc->ap_pcibsc.secbus)); }

As mav_at_ pointed out yesterday, this hack is very specific to this 
hardware.  As jhb_at_ pointed out some time ago, this problem will be 
properly addressed by his "multipass" device probing mechanism.

Sorry, there's nothing we can commit ATM.

Jung-uk Kim

> Kind Regards
> Leonardo Santagostini
>
> 2009/12/3 Giorgos Keramidas <keramida_at_freebsd.org>:
> > On Thu, 3 Dec 2009 01:57:50 +0000, Leonardo Santagostini 
<lsantagostini_at_gmail.com> wrote:
> >> Hello everybody,
> >>
> >> I was facing one big problem, i have a notebook, which is an
> >> Acer Aspire 5920.  If you like i can send to you my messages
> >> file.
> >>
> >> Which is:
> >>
> >> Intel(R) Core(TM)2 Duo CPU     T5550  _at_ 1.83GHz (1833.48-MHz
> >> 686-class CPU) Intel(R) PRO/Wireless 3945ABG
> >> Broadcom NetLink Gigabit Ethernet Controller
> >> 2 Gigs RAM
> >> 160 Gigs SATA
> >>
> >> The point was:
> >> With ACPI disabled, i managed to boot but without WIFI; and with
> >> ACPI enabled, the boot process hanged up all times.
> >>
> >> I fixed this adding
> >>
> >>     if (device_get_unit(dev)==2){
> >>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
> >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev);
> >>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
> >>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf020, 2);
> >>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf020, 2);
> >>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
> >>     }
> >>     if (device_get_unit(dev)==3){
> >>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
> >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev);
> >>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
> >>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf030, 2);
> >>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf030, 2);
> >>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
> >>     }
> >>
> >> to /usr/src/sys/dev/acpica/acpi_pcib_pci.c running on a
> >> 8.0-RELEASE
> >>
> >> I was able to fix it by my way but many people cant do it, so, i
> >> would really appreciate if you can add this piece of code.
> >
> > Hi Leonardo.
> >
> > Jung-uk Kim has done a lot of ACPI-related work, so he will
> > probably know if the change is ok to commit to stable/8.  I've
> > added him to the thread, so he can let us know what he thinks of
> > the change.  Can you please post a diff that also shows _where_
> > the changes have to be installed in our current version of
> > src/sys/dev/acpica/acpi_pcib_pci.c for 8.0-RELEASE?