Re: NOTES checker

On Friday 18 December 2009 7:27:20 am Dag-Erling Smørgrav wrote:
> Ivan Voras <ivoras_at_freebsd.org> writes:
> > John Baldwin <jhb_at_freebsd.org> writes:
> > > I wrote a little script today that crawls through sys/conf/files*,
> > > sys/conf/options*, sys/conf/NOTES, and sys/*/conf/NOTES looking for devices
> > > or options that are not tested in all the places they are valid.  If folks
> > > are interested I can commit it to src/tools.  At the moment we have 300+
> > > violations in HEAD. :)  The first few look like this:
> > What does "tested" mean in this context?
> 
> IIUC, it means "listed in NOTES on all arches that it claims to run on".

Yes.  It means something like 'LINT builds will test this option'.

> > > WARN: device acpi_aiboost is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_asus is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_dock is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_fujitsu is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_hp is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_ibm is defined globally but only tested in i386 NOTES
> > > WARN: option ACPI_MAX_TASKS is defined globally but never tested
> > > WARN: option ACPI_MAX_THREADS is defined globally but never tested
> > > WARN: device acpi_panasonic is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_sony is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_toshiba is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_video is defined globally but only tested in i386 NOTES
> > > WARN: device acpi_wmi is defined globally but only tested in i386 NOTES
> 
> The bug here is not that they aren't tested outside i386, but that they
> are defined globally (although some of them, perhaps even all, are also
> valid on amd64)

Yep.  Either way it is still "buggy".

-- 
John Baldwin