Re: patch r187693 breaks HAL on amd64-current

I have checked follow patch. After rebuild kernel with that,
hald works well and issues around hald have gone away on
FreeBSD 8-current/amd64.

I guess recent amd64 X.Org odd issues depends on
this change. ASAP quick merging is important.

Thanks

Ralph Zitz wrote:
> Thanks!
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Ralph Zitz wrote:
>>> I'm not a HAL expert, but it seems that the patch makes HAL create a
>>> zombie process when watching /dev/cd0. Reversing the patch makes HAL
>>> work again.
>>>
>>> Link to patch message:
>>> http://lists.freebsd.org/pipermail/svn-src-all/2009-January/004073.html
>>>
>> Hi Ralph
>>
>> Try the following patch, it should fix your problem with hal.
>>
>> Regards
>>
>> Steph
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v2.0.10 (FreeBSD)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iEYEARECAAYFAkmGB9YACgkQmdOXtTCX/nt8tACgj5IzDaHDEsKIJbZPefOwzkiW
>> Ne4AoMV4GzfMLeVeBAWIRbmG08R7Lpj3
>> =K7Cu
>> -----END PGP SIGNATURE-----
>> Index: kern/sys_generic.c
>> ===================================================================
>> --- kern/sys_generic.c	(revision 187983)
>> +++ kern/sys_generic.c	(working copy)
>> _at__at_ -903,7 +903,7 _at__at_
>>   * bit position in the fd_mask array.
>>   */
>>  static __inline int
>> -selflags(fd_mask **ibits, int idx, int bit)
>> +selflags(fd_mask **ibits, int idx, fd_mask bit)
>>  {
>>  	int flags;
>>  	int msk;
>> _at__at_ -912,7 +912,7 _at__at_
>>  	for (msk = 0; msk < 3; msk++) {
>>  		if (ibits[msk] == NULL)
>>  			continue;
>> -		if ((ibits[msk][idx] & (fd_mask)bit) == 0)
>> +		if ((ibits[msk][idx] & bit) == 0)
>>  			continue;
>>  		flags |= select_flags[msk];
>>  	}
>>
> 
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"

-- 
   Daichi GOTO, http://people.freebsd.org/~daichi