Re: HEADSUP usb2/usb4bsd to become default in GENERIC

Alfred Perlstein schrieb:
> Hello -current and -usb.
> 
> We are in the final stages of bringing in the new usb
> stack.
[...]
> At this point we expect there to be no style or changes in usb2
> that are not bugfixes until Phase 3 "Hand off".  The reason for
> this is to prevent bugs from creeping in and allow the maintainer
> to focus 100% on bugs and feature parity with the oldusb stack.

cparser identifies 40 variables in libusb20 and the usb2 code, which are 
only assigned, but never read. I think it's worrisome that 12 of these 
are named "err" or "error". This should be investigated, so here's the 
complete list:

> lib/libusb20/libusb20_desc.c:509: warning: variable 'dummy' is never read
> lib/libusb20/libusb20_desc.c:665: warning: variable 'dummy' is never read
> sys/dev/usb2/controller/at91dci.c:1829: warning: variable 'use_polling' is never read 
> sys/dev/usb2/controller/at91dci_atmelarm.c:77: warning: variable 'temp' is never read
> sys/dev/usb2/controller/at91dci_atmelarm.c:250: warning: variable 'err' is never read
> sys/dev/usb2/controller/atmegadci.c:777: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/atmegadci.c:780: warning: variable 'ep_no' is never read
> sys/dev/usb2/controller/atmegadci.c:1698: warning: variable 'use_polling' is never read 
> sys/dev/usb2/controller/atmegadci.c:2151: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/ehci2.c:2308: warning: variable 'slot' is never read
> sys/dev/usb2/controller/musb2_otg.c:899: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/musb2_otg.c:1124: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/musb2_otg.c:1127: warning: variable 'ep_no' is never read
> sys/dev/usb2/controller/musb2_otg.c:2235: warning: variable 'use_polling' is never read 
> sys/dev/usb2/controller/musb2_otg.c:2697: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/musb2_otg_atmelarm.c:165: warning: variable 'err' is never read
> sys/dev/usb2/controller/ohci2.c:2501: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/ohci2_atmelarm.c:151: warning: variable 'err' is never read
> sys/dev/usb2/controller/uhci2.c:1297: warning: variable 'token' is never read
> sys/dev/usb2/controller/uhci2.c:2986: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/uss820dci.c:821: warning: variable 'sc' is never read 
> sys/dev/usb2/controller/uss820dci.c:824: warning: variable 'ep_no' is never read
> sys/dev/usb2/controller/uss820dci.c:1847: warning: variable 'use_polling' is never read 
> sys/dev/usb2/controller/uss820dci_atmelarm.c:206: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_busdma.c:202: warning: variable 'error' is never read
> sys/dev/usb2/core/usb2_compat_linux.c:337: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_compat_linux.c:355: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_compat_linux.c:1181: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_compat_linux.c:1274: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_dev.c:1753: warning: variable 'resid' is never read
> sys/dev/usb2/core/usb2_dev.c:1896: warning: variable 'resid' is never read
> sys/dev/usb2/core/usb2_device.c:925: warning: variable 'err' is never read
> sys/dev/usb2/core/usb2_util.c:275: warning: variable 'err' is never read
> sys/dev/usb2/serial/umoscom2.c:525: warning: variable 'lsr' is never read
> sys/dev/usb2/sound/uaudio2.c:795: warning: variable 'ep_sync' is never read
> sys/dev/usb2/sound/uaudio2.c:2001: warning: variable 'd1' is never read 
> sys/dev/usb2/storage/ata-usb2.c:328: warning: variable 'has_intr' is never read
> sys/dev/usb2/storage/umass2.c:1636: warning: variable 'err' is never read
> sys/dev/usb2/storage/ustorage2_fs.c:906: warning: variable 'file_offset' is never read 
> sys/dev/usb2/storage/ustorage2_fs.c:907: warning: variable 'amount_left' is never read 

(For easy processing copy the list into $FILE and use "vim -q $FILE")

Regards
	Christoph