Re: Patch for 'zfs send -R' core dump (pr bin/130105)

From: Roman Divacky <rdivacky_at_freebsd.org>
Date: Thu, 19 Feb 2009 19:11:14 +0100
btw.... I track the opensolaris hg at work and there's a quite a few commits
to zfs (almost) every week. fixing coredumps and other problems.

maybe we can track the opensolaris a little closer?


On Thu, Feb 19, 2009 at 10:02:41AM -0800, George Hartzell wrote:
> 
> The following patch to
> 
>   /usr/src/sys/cddl/contrib/opensolaris/common/zfs/zfs_prop.c
> 
> seems to keep 'zfs send -R' from dumping core.  I've only been able to
> test sending the stream to /dev/null or a file, I'm still setting up a
> pool to do the receiving.
> 
> This is based on a bit of gdb debugging and a thread from zfs-fuse:
> 
>    http://groups.google.com/group/zfs-fuse/browse_thread/thread/158cb78bc3325ae3/6a0109c7b0942707?#6a0109c7b0942707
> 
> g.
> 
> --- zfs_prop.c	2009/02/17 18:58:58	1.1
> +++ zfs_prop.c	2009/02/19 09:54:04
> _at__at_ -297,7 +297,7 _at__at_
>  
>  	/* hidden properties */
>  	register_hidden(ZFS_PROP_CREATETXG, "createtxg", PROP_TYPE_NUMBER,
> -	    PROP_READONLY, ZFS_TYPE_DATASET, NULL);
> +	    PROP_READONLY, ZFS_TYPE_DATASET, "CREATETXG");
>  	register_hidden(ZFS_PROP_NUMCLONES, "numclones", PROP_TYPE_NUMBER,
>  	    PROP_READONLY, ZFS_TYPE_SNAPSHOT, NULL);
>  	register_hidden(ZFS_PROP_NAME, "name", PROP_TYPE_STRING,
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
Received on Thu Feb 19 2009 - 17:14:20 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:42 UTC