Re: CFR: usb switchover patches

From: Joe Marcus Clarke <marcus_at_marcuscom.com>
Date: Mon, 23 Feb 2009 18:46:23 -0500
On Mon, 2009-02-23 at 15:43 -0800, Andrew Thompson wrote:
> On Mon, Feb 23, 2009 at 06:37:14PM -0500, Joe Marcus Clarke wrote:
> > On Thu, 2009-02-19 at 19:37 -0800, Andrew Thompson wrote:
> > > Hi,
> > > 
> > > 
> > > I have put together a proposed set of changes for moving USB2 to its
> > > permanent location. The layout has some differences to how it is right
> > > now so I am looking for feedback.
> > > 
> > > The changeover requires that the old usb stack be available until 8.0 is
> > > branched and moves it from sys/dev/usb to sys/legacy/dev/usb. The reason
> > > for this location is to reduce the changes in #includes (using -I
> > > compiler hacks). The patch doesnt show userland changes required for
> > > usbdevs and friends but they will be done.
> > > 
> > > Some ports will break. Any that exist solely for the old usb stack can
> > > be marked broken (like udesc_dump). I dont know that the fallout will be
> > > like for the others, maybe portmgr would be interested in doing a build
> > > test.
> > > 
> > > The change roughly goes
> > > 
> > >  svn move sys/dev/usb -> sys/legacy/dev/usb
> > >  svn move sys/dev/usb2 -> sys/dev/usb (with fixups, see below)
> > 
> > The headers for usb are no longer installed.  This rebreaks hal as I
> > attempt to build both backends.  Can you make sure the old usb headers
> > are also installed (/usr/include/dev/legacy/usb)?  Without this, I will
> > have to redo the hal build code.
> 
> I was hoping I wouldnt have to do this as it breaks kdump since they
> both define the same typedefs. kdump builds its tables from trolling
> /usr/include.

Can the legacy directory be ignored?

> 
> I will have a look at this.

Thanks.  I know I'm going to start get build error reports soon.  I'd
like to put this to bed.

Joe

> 
> Andrew
> 
-- 
PGP Key : http://www.marcuscom.com/pgp.asc

Received on Mon Feb 23 2009 - 22:46:05 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:42 UTC