In message: <8F22F980-0D4C-4074-8685-3FFAD4558362_at_mac.com> Marcel Moolenaar <xcllnt_at_mac.com> writes: : : On Jan 3, 2009, at 9:42 AM, M. Warner Losh wrote: : : > In message: <440945C2-252E-489A-902E-A499753A5EF8_at_mac.com> : > Marcel Moolenaar <xcllnt_at_mac.com> writes: : > : : > : On Jan 2, 2009, at 10:14 PM, M. Warner Losh wrote: : > : : > : > In message: <20090103033543.GB77475_at_dragon.NUXI.org> : > : > "David O'Brien" <obrien_at_freebsd.org> writes: : > : > : On Fri, Jan 02, 2009 at 11:47:57AM -0700, M. Warner Losh wrote: : > : > : > In message: <20090102091334.GA41230_at_dragon.NUXI.org> : > : > : > "David O'Brien" <obrien_at_freebsd.org> writes: : > : > : > : Before 'fsck' would read the lable for the FS type. That : > has : > : > changed and : > : > : > : thus you cannot just 'fsck /dev/ad1s1d' anymore. So the FS : > : > type in fstab : > : > : > : must be accurate. : > : > : > : > : > : > Why did that change? I routinely have disks that aren't in my : > : > : > /etc/fstab that I mount and this is a pain in the backside. : > : > : : > : > : Due to r186240 which: : > : > : Make gpart the default partitioning class on all platforms. : > : > : : > : > : Seems GEOM_PART_BSD does not like labels that GEOM_BSD did. : > : > : > : > Then why the change? Shouldn't we make it like them for : > : > compatibility? : > : : > : David's statement is incorrect. They like the same labels : > : for all practical purposes. The problem at hand here is : > : that fsck(8) & newfs(8) ask of GEOM_BSD what the partition : > : type is. This means 2 things: : > : 1. Any platform that doesn't use the BSD disklabel by : > : default needs to have a proper /etc/fstab and is not : > : behaving the same as i386. : > : 2. Switching to GPT as the default partitioning scheme : > : yields the same problem. : > : : > : As I said in an email to arch_at_, it's good to query the : > : partition type to determine what to do when more specific : > : information is missing (running fsck(8) vs fsck_ffs(8)). : > : But it wasn't something that was there at the switchover : > : point. : > : > But my problems are with a platform that has BSD labels, and not GPT : > labels, with a proper BSD label on the device. : : You don't have GEOM_BSD to service the DIOCGDINFO ioctl(2) : anymore. We need to change fsck(8) so that it doesn't work : only on BSD disk labels, but instead obtains the partition : type (if applicable) in a more generic way so that it also : applies to other partitioning schemes. Agreed. Do you have a proposal for how to do that? WarnerReceived on Sat Jan 03 2009 - 17:14:21 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:39 UTC