Re: RFC: new utility, kmodpatch

On Sat, Jan 03, 2009 at 09:44:58PM +0300, Alex Keda wrote:
> Luigi Rizzo ??????????:
> >I mentioned this utility a couple of months ago, and it's now working
> >so i would like to receive feedback on whether this is good to have
> >as part of the system, or just keep it as a port (which is what
> >i plan to do by default).
> >
> >In a nutshell, the kmodpatch utility can print or alter the content
> >of device/quirk tables in kernel modules (I think Linux has some
> >similar tool, though i don't remember the name -- or perhaps it is
> >a feature of insmod ?).
> >
> >Full manpage is attached at the end, full sources are at
> >
> >    http://info.iet.unipi.it/~luigi/FreeBSD/20090101-kmodpatch.tgz
> 
> cannot build
> HP$ gunzip  --stdout 20090101-kmodpatch.tgz | tar --extract --file=-

is this on amd64 ?
in any case, as a temporary workaround just cast the arguments as
suggested by the warnings.

	cheers
	luigi

> HP$ cd kmodpatch
> HP$ ll
> total 32
> -rw-r--r--  1 lissyara  wheel   132B  1 ?????? 23:08 Makefile
> -rw-r--r--  1 lissyara  wheel   6,1K  1 ?????? 23:07 kmodpatch.8
> -rw-r--r--  1 lissyara  wheel    16K  1 ?????? 22:48 kmodpatch.c
> HP$ make
> cc -O2 -pipe  -O1 -Wall -Werror -Wunused -g -I/usr/local/include 
> -L/usr/local/lib -lkvm  kmodpatch.c  -o kmodpatch
> cc1: warnings being treated as errors
> kmodpatch.c: In function 'dump':
> kmodpatch.c:234: warning: format '%d' expects type 'int', but argument 3 
> has type 'size_t'
> kmodpatch.c:291: warning: format '%016llx' expects type 'long long 
> unsigned int', but argument 3 has type 'uint64_t'
> kmodpatch.c: In function 'do_rw':
> kmodpatch.c:535: warning: format '%d' expects type 'int', but argument 5 
> has type 'size_t'
> *** Error code 1
> 
> Stop in /tmp/kmodpatch.
> HP$