On Jan 4, 2009, at 4:29 PM, Maxim Sobolev wrote: > Luigi Rizzo wrote: >> I need to extract value and size of some symbols from an ELF file, >> and make them available to a C program, something like >> nm -S /boot/kernel/kernel | grep -E "(kernload|kernbase| >> uscanner_devs)" >> Rather than using the above tools plus popen() and some parsing code, >> I have refactored src/usr.bin/elfdump/elfdump.c , >> making the main routine externally callable, returning the >> desired info in a struct rather than print them out. >> I don't know if/how other programs might need to call elfdump(), >> but given that the changes I made have no functional or performance >> drawback, I would like to commit them to the tree. >> Objections ? >> (note, the diff will be large because in the process I also removed >> global variables and staticize/constify things) > > Why not make this function part of libelf? Please don't. libelf has a standard and well-documented API. Don't add random or one-off functions simply on the basis of them having "elf" in the name. In fact, elfdump(1) should really use libelf(3) to read ELF files. -- Marcel Moolenaar xcllnt_at_mac.comReceived on Mon Jan 05 2009 - 01:32:18 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:40 UTC