Re: [PATCH]: set C dialect when compiling world

From: Dag-Erling Smørgrav <des_at_des.no>
Date: Sat, 17 Jan 2009 16:28:27 +0100
Roman Divacky <rdivacky_at_freebsd.org> writes:

> On Tue, Jan 13, 2009 at 10:55:20PM +0100, Roman Divacky wrote:
>> hi
>> 
>> in my effort to make world compile in gnu99 mode I'd like this
>> patch to be commited:
>> 
>> Index: bsd.sys.mk
>> ===================================================================
>> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
>> retrieving revision 1.47
>> diff -u -r1.47 bsd.sys.mk
>> --- bsd.sys.mk	23 Jul 2008 06:14:21 -0000	1.47
>> +++ bsd.sys.mk	13 Jan 2009 21:36:04 -0000
>> _at__at_ -8,8 +8,11 _at__at_
>>  
>>  # for GCC:  http://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_3.html#IDX143
>>  
>> -.if !defined(NO_WARNS) && ${CC} != "icc"
>> -. if defined(CSTD)
>> +# the default is gnu89 for now
>> +. if !defined(CSTD)
>> +CSTD		= gnu89
>> +. endif
>> +
>
> CSTD	+= gnu89
>
> of course :)

Why "of course"?  Can you explain the expected semantics when CSTD
contains more than one word?

>> +. if !defined(CSTD)
>> +CSTD		= gnu89
>> +. endif

DES
-- 
Dag-Erling Smørgrav - des_at_des.no
Received on Sat Jan 17 2009 - 14:28:29 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:40 UTC