Re: [PATCH] bsdcpio core dump

On Tue, 20 Jan 2009 22:28:28 +0100, Christoph Mallon <christoph.mallon_at_gmx.de> wrote:
> Giorgos Keramidas schrieb:
>> diff -r cb9a95f8dfb3 usr.bin/cpio/cpio.c
>> --- a/usr.bin/cpio/cpio.c	Tue Jan 20 21:45:52 2009 +0200
>> +++ b/usr.bin/cpio/cpio.c	Tue Jan 20 22:56:48 2009 +0200
>> _at__at_ -623,12 +623,12 _at__at_
>>  	r = archive_write_header(cpio->archive, entry);
>>   	if (r != ARCHIVE_OK)
>> -		cpio_warnc(archive_errno(cpio->archive),
>> +		cpio_warnc(0,
>>  		    "%s: %s",
>> -		    destpath,
>> +		    srcpath,
>>  		    archive_error_string(cpio->archive));
>
> Wouldn't it be better to remove the manually appended error string,
> i.e. ": %s" ... archive_error_string(), instead of circumventing the
> generic error reporting magic provided by cpio_warnc()?

That's probably better.   It's why I split the patch in two parts, so
Tim can review them separately and pick whatever is nicer :)

It might be better to use:

        cpio_warnc(archive_errno(cpio->archive),
            "%s", srcpath);