Re: ppc hints ignored? Was: [PATCH] ppbus/ppc locking

John Baldwin wrote:
> Please test!  This is the last non-MPSAFE network driver at this point.  
> this patch adds locking for the ppbus(4)/ppc(4) devices and the various ppbus 
> child devices (lpt, vpo, lpbb, ppi, pps).  The basic model is that a single
> mutex in the ppc(4) driver protects the ppc0 hardware and is shared with the 
> various child drivers.  Two drivers now have detach methods that did not have 
> them before (plip and ppi).  I've done some simple testing on my laptop (able 
> to load the drivers and do some simple things w/o panic'ing or tripping 
> assertions), but I am not really able to test the peripheral drivers fully.
>
> http://www.FreeBSD.org/~jhb/patches/ppc_locking.patch
>
Hello!

I have also got panic around PPC_ASSERT_LOCKED(ppc) in ppc.c:1983
(cvsup-ed at app. Sat Jan 24 16:30 UTC 2009)
What I noticed is that having:

hint.ppc.0.at="isa"
hint.ppc.0.disabled="1"
hint.ppc.0.irq="7"

does not prevent ppc from attaching.
Rebooted with old kernel:

FreeBSD wep4035 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Jan 14 22:02:23 CET 2009     root_at_wep4035:/usr/obj/usr/src/sys/NOUSB  amd64

and it also attached ppc despite the line in device.hints.

Looks like not a ppc fault.
???

Alexey.