Re: ndis lor: hal preemption lock

From: Paul B. Mahol <onemda_at_gmail.com>
Date: Sun, 19 Jul 2009 19:28:10 +0200
On 7/15/09, Paul B. Mahol <onemda_at_gmail.com> wrote:
> On 7/4/09, Paul B. Mahol <onemda_at_gmail.com> wrote:
>> On 6/18/09, Coleman Kane <cokane_at_freebsd.org> wrote:
>>> I've committed this one as r194432.
>>
>> Ah, that one introduced regression.
>> Switching ndisX up before creating vap will cause panic.
>> Here is fix:
>>
>> --- /sys/dev/if_ndis/if_ndis.c  2009-06-28 09:15:54.000000000 +0000
>> +++ if_ndis.c   2009-07-04 10:23:41.000000000 +0000
>> _at__at_ -2292,6 +2292,8 _at__at_
>>         ifp = sc->ifp;
>>         ic = ifp->if_l2com;
>>         vap = TAILQ_FIRST(&ic->ic_vaps);
>> +       if (vap == NULL)
>> +               return;
>>
>>         if (!NDIS_INITIALIZED(sc)) {
>>                 DPRINTF(("%s: NDIS not initialized\n", __func__));
>
> Bump!
>
> Please commit.

Beep!

kern/136895

-- 
Paul
Received on Sun Jul 19 2009 - 15:28:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:52 UTC