Re: ng_ipacct build error

Jeff Laine wrote:
> Hello list!
> 
> I have upgraded to BETA2 recently and decided to recompile net-mgmt/ng_ipacct port
> (it was compiled in 7.2 so it's kernel module refused to load).
> 
> But I stuck with this permanent stop error:
> 
> 
> 4:49pm [/ports/net-mgmt/ng_ipacct]# make
> ===>  Vulnerability check disabled, database not found
> ===>  Found saved configuration for ng_ipacct-20061223
> ===>  Extracting for ng_ipacct-20061223
> => MD5 Checksum OK for ng_ipacct-20061223.tar.gz.
> => SHA256 Checksum OK for ng_ipacct-20061223.tar.gz.
> ===>  Patching for ng_ipacct-20061223
> ===>  Applying FreeBSD patches for ng_ipacct-20061223
> ===>  Configuring for ng_ipacct-20061223
> ===>  Building for ng_ipacct-20061223
> ===> ng_ipacct (all)
> Warning: Object directory not changed from original /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ng_ipacct
> _at_ -> /usr/src/sys
> machine -> /usr/src/sys/i386/include
> :> opt_netgraph.h
> cc -O2 -pipe -DMEM_USE_ZONE -fno-strict-aliasing -g -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ng_ipacct -I. -I_at_ -I_at_/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c ng_ipacct.c
> ld  -d -warn-common -r -d -o ng_ipacct.kld ng_ipacct.o
> :> export_syms
> awk -f /sys/conf/kmod_syms.awk ng_ipacct.kld  export_syms | xargs -J% objcopy % ng_ipacct.kld
> ld -Bshareable  -d -warn-common -o ng_ipacct.ko ng_ipacct.kld
> objcopy --strip-debug ng_ipacct.ko
> ===> ipacctctl (all)
> Warning: Object directory not changed from original /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ipacctctl
> cc -O2 -pipe -DMEM_USE_ZONE -fno-strict-aliasing  -g -Wall -Wformat -std=gnu99 -fstack-protector  -c ipacctctl.c
> ipacctctl.c:146: error: 'NG_PATHLEN' undeclared here (not in a function)
> ipacctctl.c: In function 'ip_account_get_info':
> ipacctctl.c:505: warning: unused variable 'path'
> ipacctctl.c: In function 'ip_account_show':
> ipacctctl.c:602: warning: unused variable 'path'
> *** Error code 1
> 
> Stop in /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ipacctctl.
> *** Error code 1
> 
> Stop in /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct.
> *** Error code 1
> 
> Stop in /usr/ports/net-mgmt/ng_ipacct.
> *** Error code 1
> 
> Stop in /usr/ports/net-mgmt/ng_ipacct.
> 
> 
> 
> 
> Should I contact the maintainer or am I 'doing it wrong'? :)
> 
> 
> TIA
> 
> 
  #ifndef BURN_BRIDGES 	
	 /* don't use these - they will go away */ 	
	 #define NG_TYPELEN      (NG_TYPESIZ - 1) 	
	 #define NG_HOOKLEN      (NG_HOOKSIZ - 1) 	
	 #define NG_NODELEN      (NG_NODESIZ - 1) 	
	 #define NG_PATHLEN      (NG_PATHSIZ - 1) 	
	 #define NG_CMDSTRLEN    (NG_CMDSTRSIZ - 1) 	
  #endif 	
	
they went away

use NG_PATHSIZ  (or NG_PATHSIZ-1 depending on what you ar edoing wih it).