Re: Disable root mount waiting for USB

On Tuesday 28 July 2009 15:14:36 Robert Noland wrote:
> On Tue, 2009-07-28 at 16:10 +0300, Andriy Gapon wrote:
> > on 28/07/2009 15:15 Hans Petter Selasky said the following:
> > > On Tuesday 28 July 2009 13:23:18 Andriy Gapon wrote:
> > >> on 28/07/2009 13:32 Hans Petter Selasky said the following:
> > >>> Added a sysctl for this:
> > >>>
> > >>> http://perforce.freebsd.org/chv.cgi?CH=166673
> > >>
> > >> Nitpick: better/cleaner to make it a tunable, doesn't make sense to
> > >> have it as r/w sysctl.
> > >
> > > Feel free to change it once the patch gets into -current. I've sent my
> > > patchset off, and cannot change this right now.
> >
> > Hans,
> > maybe I am mistaken but I think that without TUNABLE_INT declaration or
> > TUNABLE_INT_FETCH/getenv_int call the sysctl variable won't be set from
> > kernel environment, so this sysctl will be effectively useless.
>
> That was my thinking... I don't think that sysctl will be handled in
> time to be effective.

Hi,

You are maybe right. I didn't check that. Please change it to what it should 
be, patching against USB P4's usb_controller.c, and send the unified diff off 
to Alfred so he can apply your patch on top of mine. He's currently 
integrating for me.

--HPS