Re: fsck_y_enable: use -C

On 6/1/09, Doug Barton <dougb_at_freebsd.org> wrote:
> Andriy Gapon wrote:
>> on 01/06/2009 16:20 Andriy Gapon said the following:
>>> What about the following patch?
>>> I believe that the idea behind fsck_y_enable is to try to make unattended
>>> systems
>>> with rw filesystems as recoverable as possible at the cost of potential
>>> damage to
>>> the data. The new "-C" option should not interfere with this goal, but
>>> should
>>> reduce recovery time, because currently fsck -y checks *all* filesystems
>>> from
>>> fstab, even those that are ro or clean:
>>>
>>> -C      Check if the “clean” flag is set in the superblock and skip file
>>>         system checks if file system was properly dismounted and marked
>>>         clean.
>>>
>>
>> One potential issue that I've just thought of is that fsck_msdosfs doesn't
>> seem to
>> support this option (even in a dummy way), so it would be a problem for
>> those who
>> have msdos filesystems in fstab and also have fsck_y_enable.
>
> I'm a bit concerned that we keep the current option as it is, but I
> would support adding an fsck_y_enable_flags option to allow people to
> pass -C if they are sure it will work in their environment.

IMHO that solution is much better, considering there is "-t" & "-T" flag.


-- 
Paul