Re: [head tinderbox] failure on sparc64/sparc64

From: Xin LI <delphij_at_delphij.net>
Date: Mon, 08 Jun 2009 16:49:36 -0700
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

FreeBSD Tinderbox wrote:
> cc1: warnings being treated as errors
> /src/sys/net/if_gif.c: In function 'gif_ioctl':
> /src/sys/net/if_gif.c:918: warning: cast to pointer from integer of different size
> *** Error code 1
> 
> Stop in /obj/sparc64/src/sys/LINT.
> *** Error code 1

The attached patch should fix this, any objections?

Cheers,
- --
Xin LI <delphij_at_delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)

iEYEARECAAYFAkoto48ACgkQi+vbBBjt66C98ACgvgafjQZ/MU01V8ftN6ZI9/1U
xB0AoKZipqyI0JYmBkMGNsEEYp8A0VVl
=3o5u
-----END PGP SIGNATURE-----

Index: if_gif.c
===================================================================
--- if_gif.c	(revision 193731)
+++ if_gif.c	(working copy)
_at__at_ -912,10 +912,10 _at__at_
 	case GIFSOPTS:
 		if ((error = priv_check(curthread, PRIV_NET_GIF)) != 0)
 			break;
-		if ((error = copyin(&options, &sc->gif_options,
-				sizeof(sc->gif_options)))) {
+		if ((error = copyin(ifr->ifr_data, &options,
+				sizeof(options)))) {
 			if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
-				ifr->ifr_data = (caddr_t)options;
+				sc->gif_options = options;
 			else
 				error = EINVAL;
 		}
Received on Mon Jun 08 2009 - 21:50:52 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:49 UTC