Re: proposed bio.h change

On Thu, Jun 11, 2009 at 03:28:32PM +0200, Attilio Rao wrote:
> 2009/6/11 Luigi Rizzo <rizzo_at_iet.unipi.it>:
> > I noticed that sys/sys/bio.h unnecessarily exposes various
> > structures to userland.
> > If there are no objections I would like to commit the
> > following change (moving the bio_cmd values up because
> > they are used by ggatectl)
> 
> I think you should export CMD too for this interface.

I am not sure what you are referring to with 'CMD'.

The only strings matching 'CMD' are the bio_cmd #defines,
which as i said are exported, and the uint8_t bio_cmd
field in struct bio, which is passed up by the ioctl()
as a field of a separate struct, which contains only a
subset of struct bio fields.

Anything else I don't see ?

cheers
luigi