Re: [RFC]: (void)0 instead of empty defines

From: Marcel Moolenaar <xcllnt_at_mac.com>
Date: Mon, 15 Jun 2009 12:38:27 -0700
On Jun 15, 2009, at 11:58 AM, Roman Divacky wrote:

>> Are you saying that:
>>
>> if (cond)
>>   ;
>>
>> is considered worthy of a warning by the compiler?  Is it just "if"  
>> or
>> all conditional control constructs (e.g. while)?
>>
>> I can image many instances of this construct arising from debugging
>> facilities.  This sounds like a stupid restriction and I would  
>> argue we
>> should just disable the warning.
>
> it already found a bug in csup (recently fixed by lulf). It sure can  
> be
> disabled but I'd like it to be discussed a little bit more as it  
> already
> proved to be useful.

If the patch is all we need to compile the kernel with the warning
enabled and knowing that the warning has already found real bugs,
then it's a no-brainer to me: commit.

-- 
Marcel Moolenaar
xcllnt_at_mac.com
Received on Mon Jun 15 2009 - 17:38:55 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:50 UTC