Re: [PATCH]: typo in contrib/ipf

I just commited the fix. it is worth to note that this bug
was found by clang. The wider warnings seems to be quite
useful to me....


On Mon, Jun 15, 2009 at 11:11:23PM +0200, Roman Divacky wrote:
> hi
> 
> I found this typo:
> 
> 
> Index: tools/ipfcomp.c
> ===================================================================
> RCS file: /home/ncvs/src/contrib/ipfilter/tools/ipfcomp.c,v
> retrieving revision 1.5
> diff -u -r1.5 ipfcomp.c
> --- tools/ipfcomp.c	4 Jun 2007 02:54:34 -0000	1.5
> +++ tools/ipfcomp.c	15 Jun 2009 21:10:14 -0000
> _at__at_ -382,7 +382,7 _at__at_
>  extern frentry_t *ipf_rules_out_%s[%d];\n",
>  			grp->fg_name, grp->fg_name, outcount);
>  
> -		for (g = groups; g != g; g = g->fg_next)
> +		for (g = groups; g != grp; g = g->fg_next)
>  			if ((strncmp(g->fg_name, grp->fg_name,
>  				     FR_GROUPLEN) == 0) &&
>  			    g->fg_flags == grp->fg_flags)
> 
> can someone review it? darren reed ignored my mail. is it ok
> to commit to contrib/ipf ?
> 
> thnx for the answers :)
> 
> roman
>