Re: [PATCH] AMD Opteron Rev. E hack

From: Dag-Erling Smørgrav <des_at_des.no>
Date: Thu, 05 Nov 2009 12:18:53 +0100
Giovanni Trematerra <giovanni.trematerra_at_gmail.com> writes:
> I have a quick and dirty patch to address the problem as discussed on
> commit r198868 in svn-src-head_at_
> I introduced BROKEN_OPTERON_E kernel option for i386/amd64 arch.
> The patch isn't tested yet, I only successfully compiled on i386.
> Can you let me know if the patch is on the right direction to resolve the issue?
> style(9) tips are welcomed.

We should probably call it OPTERON_E_LFENCE_HACK or something, cf.
NO_F00F_HACK (which has the opposite semantics - the f00f hack is
enabled by default, though at this point we should probably reverse it
and just print a warning if we detect a vulnerable CPU), and the wording
of those printfs needs work, but it looks OK overall.

BTW, you should use the text/x-patch MIME type for patches, instead of
application/octet-stream.

DES
-- 
Dag-Erling Smørgrav - des_at_des.no
Received on Thu Nov 05 2009 - 10:18:56 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:57 UTC