Re: [PATCH] Adding sysctl for errors statistics to ahd(4)

I don't think that there was a specific mention of newbus.  I actually  
sees storage stats being the domain of either CAM or GEOM, and far too  
specific for newbus.

Scott

Sent from my iPhone

On Nov 11, 2009, at 6:46 PM, Attilio Rao <attilio_at_freebsd.org> wrote:

> 2009/11/11 Justin T. Gibbs <gibbs_at_scsiguy.com>:
>> On 11/6/2009 7:43 AM, Attilio Rao wrote:
>>> This patch introduces some mechanisms for collecting informations on
>>> errors frequency and debugging (and relative sysctls for printing  
>>> them
>>> out) for the ahd(4) driver:
>>> http://www.freebsd.org/~attilio/Sandvine/STABLE_8/ahd/ahd-current2.diff
>>>
>>> The usage of array for sysctls is a bit too paranoid but it allows  
>>> for
>>> further extendibility of the code and doesn't loose of cleaness.
>>> This code has been contributed back by Sandvine Incorporated with  
>>> some
>>> cleanups.
>>> Please review.
>>>
>>> Thanks,
>>> Attilio
>>
>> In general, I think the patch is fine.  It violates the existing  
>> style
>> of the driver in some places (e.g. the aic7xxx drivers wrap function
>> arguments to the opening '(' not to a 4 space indent), which should
>> probably be addressed so the code remains consistent.
>
> Sorry, I cannot find where these existing style breakage happens,
> could you be a bit more precise?
> (I just found an un-sorted header introduction in aic79xx.h that I  
> will fix).
>
> Anyways, your idea about a generalized interface in newbus for
> handling that is not bad and as long as I'm planning some works in
> this area I can add this item to the TODO list.
>
> Thanks,
> Attilio
>
>
> -- 
> Peace can only be achieved by understanding - A. Einstein