Re: -Werror errors on RELENG_8_0 world

On Sat, Nov 14, 2009 at 08:43:06AM +0300, Dmitry Marakasov wrote:
> cc -O2 -pipe -Wall -march=prescott -I/usr/src/lib/msun/ld80 -I/usr/src/lib/msun/src -I/usr/src/lib/msun/../libc/include  -I/usr/src/lib/msun/../libc/i386 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign -c /usr/src/lib/msun/src/e_atan2.c
> cc1: warnings being treated as errors
> /usr/src/lib/msun/src/e_atan2.c: In function 'atan2':
> /usr/src/lib/msun/src/e_atan2.c:74: warning: suggest parentheses around arithmetic in operand of |
> *** Error code 1
> ---
> 
> There are some more, but it builds fine with NO_WERROR=1.
> 
> SVN logs show that code wasn't changed for a long time, so why
> weren't these detected and fixed yet, or am I missing something and
> this is a some local problem?
> 

I vote local problem.  However, you failed to provide sufficient
information to substantiate that vote.  What is in your make.conf,
rc.conf, src.conf, and environment that might affect the build
process?

As to why it isn't fixed yet, there's the old adage:  "If it
ain't broken, don't fix it."  More to the point, e_tan2.c comes
into FreeBSD via Sun's fdlibm, which is the basis of libm on the
other *bsd projects.   Any local cosmetic changes to e_tan2.c 
(and other fdlibm code) would make FreeBSD's code gratutiously
different from the other projects.

-- 
Steve