Re: svn commit: r199066 - head/usr.bin/gzip

From: Xin LI <delphij_at_delphij.net>
Date: Sat, 14 Nov 2009 21:04:41 -0800
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jilles Tjoelker wrote:
> On Fri, Nov 13, 2009 at 03:27:44PM -0800, Xin LI wrote:
>> The previous fix has introduced an issue that revealed another bug as
>> well (gzip -d -c can't decompress large-ish input stream, i.e. something
>> like bzip2 -c ObsoleteFiles.inc | gunzip -d -c).  The proposed patch:
> 
>>  * Set end_of_file flag if we hit a short read.  This usually saves one
>> read after the actual end of file.
> 
> A short read does not necessarily mean EOF on a pipe or other
> non-regular file.

Yes you're right, what we really need is to distinguish between an
non-existent end of file and a real short read.  I'll see if I would
have some other alternatives.

Cheers,
- --
Xin LI <delphij_at_delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (FreeBSD)

iEYEARECAAYFAkr/i+kACgkQi+vbBBjt66BqvQCgokChJF0RLKP/v1R7dNaWbtcP
wAMAn29dHIxhGRwqI0IEjZhIIwxbT63X
=g18V
-----END PGP SIGNATURE-----
Received on Sun Nov 15 2009 - 04:04:54 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:58 UTC