Re: nd6 change and rc.d/network_ipv6 -> rc.d/netif integration

On 2009-10-06 18:21, David Horn wrote:
> 1)  Patchset is missing examples and defaults for new rc.conf
> variables to /etc/defaults/rc.conf. (The defaults/rc.conf has been
> updated in -current, although perhaps once everything settles, it
> would help to expand the examples in comments)

Not only that, it would prevent the following needless warnings, which
are printed at every boot:

[...]
/etc/rc: WARNING: $ipv6_enable is obsolete.  Use $ipv6_prefer instead.
/etc/rc: WARNING: $ipv6_enable is obsolete.  Use $ipv6_prefer instead.
[...]
/etc/rc: WARNING: $ipv6_router_enable is obsolete.  Use $route6d_enable instead.
/etc/rc: WARNING: $ipv6_router is obsolete.  Use $route6d_program instead.
/etc/rc: WARNING: $router_enable is obsolete.  Use $routed_enable instead.
/etc/rc: WARNING: $router is obsolete.  Use $routed_program instead.
/etc/rc: WARNING: $router_flags is obsolete.  Use $routed_flags instead.

Although the warning about ipv6_enable could be considered right,
there's no need to print it twice, and I never touched any of the other
ipv6_* or router_* variables.  Those are from /etc/defaults/rc.conf.


> 2)  I really like the changes to ifconfig and kernel for exposing
> per-interface flags for "accept_rtadv" and other ndp flags to ifconfig
> (and inherently rc.conf).  I previously had to do some hackery to
> disable "accept_rtadv" at boot time for just one interface within
> rc.conf.

I'm not entirely sure if this is a sensible default.  I would guess that
for most users (80%? 90%?) the choice is only to have IPv6 "globally"
disabled or enabled, and only a small percentage of users will need
per-interface enabling/disabling of IPv4.

Since it's now 2009 and everybody should start using IPv6 ASAP, it might
make sense to have IPv6 globally enabled by default, with additional
options for users like David to selectively disable it for individual
interfaces.


> 3)  I would prefer that ipv6_enable remain a global flag in rc.conf,
> and NOT be obsoleted.  I would also prefer that
> ipv6_network_interfaces="auto" as in the past by default.  Again, I
> like the logic changes and the flexibility it provides, it is just the
> default/obsolete that I am interested in changing.

Seconded.  Even Windows defaults to enabling IPv6 globally for all
interfaces these days. :)


> 4) Personal opinion time:   change the "accept_rtadv" token to
> "autoconf" in ifconfig and rc.conf, as this it is a better
> self-description.  Just one persons opinion.

Since the old "global" sysctl was also called accept_rtadv, I understand
the same name was chosen for the per-interface option.  People might
confuse "autoconf" with "zeroconf" or other automatic configuration
systems.  Since the option means to accept router advertisements,
accept_rtadv seems not a very bad name to me... :)


> Given the timing, +1 for letting this bake in -current until after 8.0
> release.

Yes.  A few weeks at least.