Re: if_rum dies on transmit...

On Wed, Oct 14, 2009 at 11:08:39PM +0100, Gavin Atkinson wrote:
> On Wed, 14 Oct 2009, Weongyo Jeong wrote:
> >On Tue, Oct 13, 2009 at 05:41:09PM -0600, bsduser wrote:
> >>Weongyo Jeong <weongyo.jeong_at_gmail.com> writes:
> >>
> >>>On Tue, Sep 29, 2009 at 01:57:46PM +0000, Poul-Henning Kamp wrote:
> >>>>
> >>>>Has anybody else seen if_rum die when you try to transmit a file over
> >>>>a TCP connection ?
> >>>>
> >>>>If I try to print across the network, upload a file with ftp or anything
> >>>>else of that general tenor, if_rum seems to hang the output queue and
> >>>>stops transmitting packets.
> >>>
> >>>Could you please test with attached patch?
> >>>
> >>
> >>I had the same issues with if_rum at least while using WPA and your patch 
> >>made
> >>them go away.... ( although removing and plugging back in does not quite
> >>work )
> >>
> >># scp INDEX-8* cookie:/usr/ports
> >>INDEX-8                                       100%   19MB   2.1MB/s   
> >>00:09
> >>INDEX-8.db                                    100%   34MB   2.4MB/s   
> >>00:14
> >>
> >>before the patch this would just hang.
> >>
> >>Another quick test using rsync on a bunch of files worked flawless too.
> >>
> >>usbconfig list:
> >>
> >>ugen7.2: <Compact Wireless-G USB Adapter Cisco-Linksys> at usbus7, cfg=0
> >>md=HOST spd=HIGH (480Mbps) pwr=ON
> >>
> >>The adapter is a WUSB54GC and yes, you made my day :-)
> >
> >Patched at r198098.  Thank you for testing!
> 
> Many thanks for this!
> 
> Do you know if this patch is likely to fix the panics seen with rum(4) or 
> is this likely to only fix the TX hangs?

AFAIK this patch only fixes TX hangs.  I didn't see PRs yet related with
the panics but I think it could affect user's panic a little bit.

regards.
Weongyo Jeong