Re: newfs_msdos and DVD-RAM

on 02/04/2010 13:57 Fabian Keil said the following:
> Andriy Gapon <avg_at_freebsd.org> wrote:
>> Anyways, here is a patch that I would use.
>> Unfortunately, ENOTIME to understand newfs_msdos code and fix it too,
>>
>> --- a/sys/fs/msdosfs/msdosfs_vfsops.c
>> +++ b/sys/fs/msdosfs/msdosfs_vfsops.c
>> _at__at_ -580,6 +580,7 _at__at_ mountmsdosfs(struct vnode *devvp, struct mount *mp)
>>  	  || (pmp->pm_BytesPerSec & (pmp->pm_BytesPerSec - 1))
>>  	  || (pmp->pm_HugeSectors == 0)
>>  	  || (pmp->pm_FATsecs == 0)
>> +	  || (SecPerClust * pmp->pm_BlkPerSec > MAXBSIZE / DEV_BSIZE)
>>  	) {
>>  		error = EINVAL;
>>  		goto error_exit;
> 
> That works, too:
> 
> fk_at_r500 ~ $sudo mdconfig -a -t vnode -f /tank/ipod-image-formatiert
> md0
> fk_at_r500 ~ $sudo mount_msdosfs /dev/md0 /mnt/
> mount_msdosfs: /dev/md0: Invalid argument
> 
> Is there a chance that this, or some other workaround, could be committed?

Yes, there is 99.99% chance of this happening :-)
Now, if someone could fix newfs_msdos issue too.
I could easily reproduce it this way:

$ truncate -s 5G test.img
$ mdconfig -a -t vnode -f test.img -S 2048 -u 0
$ newfs_msdos -F 32 /dev/md0

-- 
Andriy Gapon