Re: [patch] big whitespace cleanup in sys/kern/*

From: Ulrich Spörlein <uqs_at_spoerlein.net>
Date: Wed, 4 Aug 2010 13:18:35 +0200
On Tue, 03.08.2010 at 17:21:45 -0700, Steve Kargl wrote:
> On Tue, Aug 03, 2010 at 05:40:05PM -0400, Thomas Dickey wrote:
> > On Tue, Aug 03, 2010 at 11:22:36AM -0700, Julian Elischer wrote:
> > > On 8/3/10 2:34 AM, pluknet wrote:
> > > >Hi.
> > > >
> > > >I looked into sys/kern/* files to fix a bunch of common w/s style issues 
> > > >(221):
> > > >- leading space before label;
> > > >- leading space(s) before<tab>;
> > > >- space(s) instead of<tab>(s);
> > > >- space(s) in blank like.
> > > >
> > > >I tried to be conservative and didn't touch semi-contrib files and
> > > >those with its own style.
> > > >Here is a diff I'd like someone look into and check in if there will
> > > >no objections.
> > > 
> > > The style guide suggests against wholesale cleanups and we have 
> > > generally avoided them due to teh fact that they tend to obfuscate diffs.
> > > The idea being that we clean as we go..
> > > however it may be time for one.. I'd leave it to others to decide.
> > 
> > I'm curious why there's no mention of using 'indent' (with appropriate
> > settings...).
> > 
> 
> Because there is no set of appropriate settings for indent(1)
> to reproduce style(9).

uncrustify (in ports) can be made to almost adhere to style(9). The
documentation/configuration of that tool is horrible, though.

I someone is interested in my uncrustify.cfg and wants to improve it,
drop me a line.

Uli
Received on Wed Aug 04 2010 - 09:20:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:05 UTC