Re: Official request: Please make GNU grep the default

2010/8/20 Dag-Erling Smørgrav <des_at_des.no>:
> Adrian Chadd <adrian_at_freebsd.org> writes:
>> I've just looked at grep_fgetln(). Surely memchr() isn't required there.
>
> Of course it is, how else are you going to locate the '\n'?  OTOH, I'm
> not sure grep_fgetln() is needed at all.

It seems a bit strange that memchr(), which should be hitting data
that's in the cache (as it was recently read, right?) is showing up so
high in the profiling results. memchr() in libc/string/memchr.c looks
like how I'd inline it, so, hm.

Have you tried this in pmc?


Adrian