Re: ZFS: statfs and recordsize problem

From: Pawel Jakub Dawidek <pjd_at_FreeBSD.org>
Date: Fri, 19 Feb 2010 21:18:50 +0100
On Thu, Feb 18, 2010 at 03:39:28PM +0300, Alexander Zagrebin wrote:
> I have noticed, that statfs called for ZFS file systems,
> returns the value of FS's recordsize property in both f_bsize and
> f_iosize.
> 
> It's a problem for some software.
> For example, squid uses block size of cache's file system to calculate
> the space occupied by file.
> So by default it considers that any small file uses 128KB of a cache
> (when default value of recordsize is used), though really this file
> may use 512B only.
> This miscalculation leads to unreasonable cleaning of a cache.
> 
> IMHO the behavior of statfs have to be changed, as ZFS uses variable
> (up to recordsize) block sizes.
> It must return 512 as f_bsize and recordsize as f_iosize.
> One of possible solutions is the attached patch.
> Could somebody look it?

I committed (slightly modified version of) your patch to HEAD.
Thanks!

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd_at_FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

Received on Fri Feb 19 2010 - 19:19:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:01 UTC