Re: [patch] Let indent(1) handle widecharacter literals correctly

On 2010-Jan-21 22:05:23 +0100, Tobias Rehbein <tobias.rehbein_at_web.de> wrote:
>I am not subscribed to this list, so please answer me off-list or cc me.
>
>I noticed that indent(1) handles widecharacter literals (e.g. L'c' or L"string")
>incorrectly. indent(1)s parser treats the L-prefix and the quoted part as
>seperate tokens. The result is:
>
>        L'c'            ->      L 'c'
>        L"string"       ->      L "string"

Thank you for noticing that.  Can you please submit your patch as a PR
so it doesn't get lost (send-pr(1)).

>Of course this breaks any code using widecharacters. As I use indent(1) quite
>extensively I decided to fix this issue. As this is my first patch against the
>FreeBSD user land feel free to comment!

I don't know indent(1) well enough to comment on the functional
aspects but there are some style issues with the patch.  Two lines are
longer than 80 characters and the indenting doesn't align - see
style(9).

-- 
Peter Jeremy