Re: svn commit: r210194 - head/sys/fs/unionfs

On 17.07.10 17:45, Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Sat Jul 17 15:45:20 2010
> New Revision: 210194
> URL: http://svn.freebsd.org/changeset/base/210194
>
> Log:
>    Remove updating process count by unionfs.  It serves no purpose, unionfs just
>    needs root credentials for a moment.
>
> Modified:
>    head/sys/fs/unionfs/union_subr.c
>
> Modified: head/sys/fs/unionfs/union_subr.c
> ==============================================================================
> --- head/sys/fs/unionfs/union_subr.c	Sat Jul 17 13:34:01 2010	(r210193)
> +++ head/sys/fs/unionfs/union_subr.c	Sat Jul 17 15:45:20 2010	(r210194)
> _at__at_ -50,7 +50,6 _at__at_
>   #include<sys/fcntl.h>
>   #include<sys/filedesc.h>
>   #include<sys/stat.h>
> -#include<sys/resourcevar.h>
>
>   #include<security/mac/mac_framework.h>
>
> _at__at_ -775,7 +774,6 _at__at_ unionfs_mkshadowdir(struct unionfs_mount
>   	/* Authority change to root */
>   	rootinfo = uifind((uid_t)0);
>   	cred = crdup(cnp->cn_cred);
> -	chgproccnt(cred->cr_ruidinfo, 1, 0);
>   	change_euid(cred, rootinfo);
>   	change_ruid(cred, rootinfo);
>   	change_svuid(cred, (uid_t)0);
> _at__at_ -825,7 +823,6 _at__at_ unionfs_mkshadowdir_free_out:
>
>   unionfs_mkshadowdir_abort:
>   	cnp->cn_cred = credbk;
> -	chgproccnt(cred->cr_ruidinfo, -1, 0);
>   	crfree(cred);
>
>   	return (error);
> _______________________________________________
> svn-src-head_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe_at_freebsd.org"
>
>
cc1: warnings being treated as errors
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c: 
In function 'unionfs_mkshadowdir':
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: implicit declaration of function 'uifind'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: nested extern declaration of 'uifind'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: assignment makes pointer from integer without a cast
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:780: 
warning: implicit declaration of function 'uifree'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:780: 
warning: nested extern declaration of 'uifree'

Hm, I'd like to include this one again:

[tc:fbsd/head/src] andreast% svn diff sys/fs/unionfs/union_subr.c
Index: sys/fs/unionfs/union_subr.c
===================================================================
--- sys/fs/unionfs/union_subr.c	(revision 210200)
+++ sys/fs/unionfs/union_subr.c	(working copy)
_at__at_ -50,6 +50,7 _at__at_
  #include <sys/fcntl.h>
  #include <sys/filedesc.h>
  #include <sys/stat.h>
+#include <sys/resourcevar.h>

  #include <security/mac/mac_framework.h>


Gruss,
Andreas