Re: [panic] Race in IEEE802.11 layer towards device drivers

On Tuesday 20 July 2010 12:03:22 PseudoCylon wrote:
> ----- Original Message ----
> 
> > From: Hans Petter Selasky <hselasky_at_c2i.net>
> > To: freebsd-current_at_freebsd.org
> > Cc: PseudoCylon <moonlightakkiy_at_yahoo.ca>; Sam Leffler <sam_at_freebsd.org>;
> >
> >freebsd-usb_at_freebsd.org
> >
> > Sent: Mon, July 19, 2010 1:17:04 PM
> > Subject: Re: [panic] Race in IEEE802.11 layer towards device drivers
> > 
> > Hi AK,
> > 
> > I've committed your patches to USB P4. I've made some additional 
> > patches.
> > 
> > Can you check and verify everything?
> > 
> > http://p4web.freebsd.org/_at__at_181189?ac=10
> 
> Hi
> 
> If we change sc->cmdq_run = RUN_CMDQ_ABORT,
> 
> -- begin excerpt --
> 
> 
> _at__at_ -4890,7 +4877,10 _at__at_ run_stop(void *arg)
>  ifp->if_drv_flags &= ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE);
> 
>  sc->ratectl_run = RUN_RATECTL_OFF;
> -sc->cmdq_run = RUN_CMDQ_ABORT;
> +
> +RUN_CMDQ_LOCK(sc);
> +sc->cmdq_run = sc->cmdq_key_set = RUN_CMDQ_ABORT;
> +RUN_CMDQ_UNLOCK(sc);
> 
> -- end excerpt --
> 
> 
> we also need to change this, otherwise key will be cleared.

Ok.

Try to give the second mutex a different name, and see how many warnings go 
away.

--HPS