Re: [CFT] BSDL iconv in base system

From: Alexander Best <alexbestms_at_uni-muenster.de>
Date: Tue, 15 Jun 2010 22:01:44 +0200
On Tue, Jun 15, 2010 at 7:56 PM, Alexander Best
<alexbestms_at_uni-muenster.de> wrote:
> On Tue, Jun 15, 2010 at 7:42 PM, Gabor Kovesdan <gabor_at_freebsd.org> wrote:
>>
>>> /usr/src/lib/libc/iconv/citrus_none.c: In function
>>> '_citrus_NONE_stdenc_cstomb':
>>> /usr/src/lib/libc/iconv/citrus_none.c:114: warning: unused variable 'ret'
>>> *** Error code 1
>>>
>>
>> I'm sorry, this one slipped in. Today I've checked the sources with clang
>> and fixed some minor warnings, including this one. The new patch is here:
>> http://www.kovesdan.org/patches/iconv_base_integrate2.diff
>>
>> And a gzipped version:
>> http://www.kovesdan.org/patches/iconv_base_integrate2.diff.gz
>
> thanks. i'll revert the previous patch and apply this new one.

with the new patch:

===> lib/libiconv_modules (all)
===> lib/libiconv_modules/BIG5 (all)
cc -fpic -DPIC -O2 -pipe -fno-strict-aliasing -funroll-loops
-march=native --param max-inline-insns-single=32
-I/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv -g -std=gnu99
-fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
-Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch
-Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline
-Wnested-externs -Wredundant-decls -Wold-style-definition
-Wno-pointer-sign -c /usr/src/lib/libiconv_modules/BIG5/citrus_big5.c
-o citrus_big5.So
cc1: warnings being treated as errors
/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.h:
In function '_citrus_BIG5_stdenc_cstomb':
/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.h:138:
warning: 'ret' may be used uninitialized in this function
*** Error code 1

Stop in /usr/src/lib/libiconv_modules/BIG5.
*** Error code 1

Stop in /usr/src/lib/libiconv_modules.
*** Error code 1

Stop in /usr/src/lib.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.


>
> cheers.
> alex
>
>>
>> --
>> Gabor Kovesdan
>> FreeBSD Volunteer
>>
>> EMAIL: gabor_at_FreeBSD.org .:|:. gabor_at_kovesdan.org
>> WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
>>
>>
>
>
>
> --
> Alexander Best
>



-- 
Alexander Best
Received on Tue Jun 15 2010 - 18:01:51 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:04 UTC