Re: Patch for rc.d/devd on FreeBSD 9-current

From: Dag-Erling Smørgrav <des_at_des.no>
Date: Mon, 28 Jun 2010 16:35:36 +0200
"M. Warner Losh" <imp_at_bsdimp.com> writes:
> Dag-Erling Smørgrav <des_at_des.no> writes:
> > "M. Warner Losh" <imp_at_bsdimp.com> writes:
> > > Maybe the real problem is that devd locks the file, then dies.  The
> > > file remains locked, so the flopen is failing with EWOULDBLOCK.
> > The lock is released when the process that holds it terminates.
> So which process is that?  devd took it out, and is subsequently
> killed.  When it restarts, it can't take out the lock.

What does fstat say about the pid file?

> The same code works perfectly in 8.0-stable from April.
>
> The conclusion, I believe, is that somebody broke locking in
> current...

Before I wrote one of my earlier replies, I traced through the code
paths that lead to a lock being released, and everything looks fine and
dandy.  Besides, if someone had, as you suggest, broken locking in
current, there would be a lot more noise about it on the lists.

DES
-- 
Dag-Erling Smørgrav - des_at_des.no
Received on Mon Jun 28 2010 - 12:37:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:05 UTC