Re: Patch for rc.d/devd on FreeBSD 9-current

From: M. Warner Losh <imp_at_bsdimp.com>
Date: Tue, 29 Jun 2010 11:15:48 -0600 (MDT)
In message: <86r5jqdz9w.fsf_at_ds4.des.no>
            Dag-Erling Smørgrav <des_at_des.no> writes:
: "M. Warner Losh" <imp_at_bsdimp.com> writes:
: > +		/*
: > +		 * Close the PID file, and all other open descriptors.
: > +		 * Inherit std{in,out,err} only.
: > +		 */
: > +		cfg.close_pidfile();
: > +		::closefrom(3);
: 
: Actually, closefrom() is sufficient, since the only resource held by the
: pidfile that would persist across execve() is the file descriptor (and
: hence the lock).

I went ahead and used pidfile_close in this context because that's
what's recommended in the man page.  I know it is likely redundant,
but I thought better safe than sorry...

Warner
Received on Tue Jun 29 2010 - 15:26:21 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:05 UTC