Re: newfs failure on -current

In message: <98a59be81003040504x6e97fbaeqeb10f8ea7bedb7b9_at_mail.gmail.com>
            "C. Jayachandran" <c.jayachandran_at_gmail.com> writes:
: I'm testing this on the mips platform, but I think there is an issue
: with change that made sectorsize int64_t, because the ioctl
: DIOCGSECTORSIZE  used to read sector size seems to take u_int. This
: quick change fixes it for me (sample patch - may be whitespace
: damaged).
: 
: Index: sbin/newfs/newfs.c
: ===================================================================
: --- sbin/newfs/newfs.c  (revision 204687)
: +++ sbin/newfs/newfs.c  (working copy)
: _at__at_ -327,9 +327,11 _at__at_
:                 mediasize = st.st_size;
:                 /* set fssize from the partition */
:         } else {
: +           u_int tsize;
:             if (sectorsize == 0)
: -               if (ioctl(disk.d_fd, DIOCGSECTORSIZE, &sectorsize) == -1)
: +               if (ioctl(disk.d_fd, DIOCGSECTORSIZE, &tsize) == -1)
:                     sectorsize = 0;     /* back out on error for safety */
: +           sectorsize = tsize;
:             if (sectorsize && ioctl(disk.d_fd, DIOCGMEDIASIZE,
: &mediasize) != -1)
:                 getfssize(&fssize, special, mediasize / sectorsize, reserved);
:         }
: 

Maybe the right change is to back out the DIOCGSECTORSIZE change due
to silent breakage like this?

Warner